Skip to content

feat: add more intelligent error screen#383

Merged
jonas-jonas merged 8 commits intomainfrom
jonas-jonas/errorScreen
Mar 12, 2025
Merged

feat: add more intelligent error screen#383
jonas-jonas merged 8 commits intomainfrom
jonas-jonas/errorScreen

Conversation

@jonas-jonas
Copy link
Copy Markdown
Member

@jonas-jonas jonas-jonas commented Mar 10, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Mar 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.49020% with 38 lines in your changes missing coverage. Please review.

Project coverage is 48.97%. Comparing base (f3fad4d) to head (4b3cb21).
Report is 60 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   42.43%   48.97%   +6.54%     
==========================================
  Files         136      141       +5     
  Lines        2008     2234     +226     
  Branches      288      340      +52     
==========================================
+ Hits          852     1094     +242     
+ Misses       1149     1127      -22     
- Partials        7       13       +6
Components Coverage Δ
@ory/elements-react 45.60% <32.65%> (+8.81%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonas-jonas jonas-jonas requested a review from pcaillaudm March 12, 2025 12:09
@jonas-jonas jonas-jonas marked this pull request as ready for review March 12, 2025 12:47
pcaillaudm
pcaillaudm reviewed Mar 12, 2025
View reviewed changes
@jonas-jonas jonas-jonas enabled auto-merge (squash) March 12, 2025 15:10
@jonas-jonas jonas-jonas merged commit 0e195ec into main Mar 12, 2025
10 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/errorScreen branch March 12, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcaillaudm pcaillaudm pcaillaudm approved these changes

Assignees

@jonas-jonas jonas-jonas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonas-jonas @pcaillaudm @ory-bot